Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Heading permalink extension not being enabled when compiling the body for documentation pages #231

Closed
caendesilva opened this issue May 2, 2022 · 0 comments

Comments

@caendesilva
Copy link
Member

This is because the extension gets enabled automatically when the source model is set to DocumentationPage, however, the StaticPageBuilder.php never supplies that parameter to the Markdown converter.

Desired behavior is fixed by changing

 'markdown' => MarkdownConverter::parse($this->page->body),

To

'markdown' => (new MarkdownConverterService($this->page->body, DocumentationPage::class))->parse(),
caendesilva pushed a commit that referenced this issue Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant