Merge options from site.php config into hyde.php #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
force-pushed
the
merge-site-config-into-hyde-config
branch
from
7c0b7df to
e8a65fe
Compare
Codecov Report
@@ Coverage Diff @@
## separate-internal-application-files-from-project-structure- #964 +/- ##
=================================================================================================
Coverage 100.00% 100.00%
+ Complexity 2532 1266 -1266
=================================================================================================
Files 302 151 -151
Lines 6680 3339 -3341
=================================================================================================
- Hits 6680 3339 -3341 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Replace `config('site')` calls with `config('hyde')`
Replace `config(['site'])` calls with `config(['hyde'])`
Replace `Config::get('site')` calls with `Config::get('hyde')`
caendesilva
force-pushed
the
merge-site-config-into-hyde-config
branch
from
aeb8425 to
73143af
Compare
caendesilva
commented
Feb 11, 2023
caendesilva
force-pushed
the
merge-site-config-into-hyde-config
branch
from
df506f4 to
38ac03c
Compare
…ure-' into merge-site-config-into-hyde-config
…ure-' into merge-site-config-into-hyde-config
caendesilva
merged commit 0cff459
into
separate-internal-application-files-from-project-structure-
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Highly experimental PR to merge the site.php config file with the hyde.php one.
Upgrade path for existing installations
Step one - Move config settings
Start by copying all the options in the
config/site.phpconfig toconfig/hyde.phpStep two - Update config calls
Next, if you have written custom code, or created/published any Blade views, that calls
config('site.XXX')you need to replace that withconfig('hyde.XXX')This is fairly easy using search+replace across files in VS Code or another modern code editor or IDE. Try searching for
'site.and you'll find matches needing replacement. See 73143af for an example for what you want.