Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggressively simplify and inline action FindsContentLengthForRemoteImageObject #616

Merged
merged 38 commits into from
Oct 29, 2022
Merged

Aggressively simplify and inline action FindsContentLengthForRemoteImageObject #616

merged 38 commits into from
Oct 29, 2022

Conversation

caendesilva
Copy link
Member

No description provided.

caendesilva and others added 30 commits October 28, 2022 21:04
@caendesilva
Move class namespace
305fd3b
@caendesilva
Fix use function statement
ae91036
@caendesilva
Merge multiple method calls into concatenation
2e673de
@caendesilva
First output message needs newline
47a5de0
@caendesilva
Merge branch 'experimental' into refactor-FindsContentLengthForImageO…
939e045 
…bject
@caendesilva
Retrieve output from session
7ae0733
@caendesilva
Set default value to false
aa9cccc
@caendesilva
Merge branch 'experimental' into refactor-FindsContentLengthForImageO…
952e78c 
…bject
@caendesilva
Set the console output in session so it can be used by actions
587757a
@caendesilva
Revert "Set the console output in session so it can be used by actions"
4087642 
This reverts commit 587757a.
@caendesilva
Put warnings in session
d02d1e5
@caendesilva
Aggressively simplify action
c8aa6f7
@caendesilva
Aggressively simplify action even more
a875b94 
Since we don't validate if other links are valid, why should we here?
@caendesilva
Inline action FindsContentLengthForRemoteImageObject
55529e7
@caendesilva
Method getPath must not return basename
07e8aa5
@caendesilva
Simplify if with ??
b40c2f7
@caendesilva
Change private to protected
f091053
@caendesilva
Remove unused import
6efef4c
@caendesilva
Delete FindsContentLengthForImageObjectTest.php
9e0432e
@StyleCIBot
Apply fixes from StyleCI
ff1d89b
@caendesilva
Force internal image path property to always begin with _media/
d5edccc
@StyleCIBot
Apply fixes from StyleCI
582f8d9
@caendesilva
Test normalizing
41397e0
@caendesilva
Assert same
5755159
@caendesilva
Expect normalized path
e94af16
@caendesilva
Support media/file as input
6b93514
@caendesilva
Move down method to group constructors
c2e488e
@caendesilva
Expect normalized path
d4f544f
@caendesilva
Revert "Expect normalized path"
866cf16 
This reverts commit d4f544f.
@caendesilva
Revert "Expect normalized path"
e009081 
This reverts commit e94af16.
@caendesilva caendesilva marked this pull request as ready for review October 29, 2022 07:18
@caendesilva caendesilva merged commit 3cf22da into experimental Oct 29, 2022
@caendesilva caendesilva deleted the refactor-FindsContentLengthForImageObject branch October 29, 2022 07:18
@caendesilva caendesilva mentioned this pull request Oct 29, 2022
Merged
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caendesilva @StyleCIBot