Replace schema traits with interface constants

RELEASE_NOTES.md

@@ -26,13 +26,15 @@ In general, these changes should only affect those who have written custom code
 - Renamed HydeBuildStaticSiteCommand to HydeBuildSiteCommand
 - Renamed legacy FileCacheService to ViewDiffService
 - Renamed method `Hyde::getSiteOutputPath()` to `Hyde::sitePath()`
+- Replaced schema traits with interfaces, see https://github.com/hydephp/develop/pull/485
 - Extracted all constructor methods in page schema traits to a new single trait ConstructPageSchemas
 - The `StaticPageBuilder::$outputPath` property is now a relative path instead of absolute
 
 ### Deprecated
 - for soon-to-be removed features.
 
 ### Removed
+- Removed all experimental schema traits
 - Removed interface IncludeFacadeContract
 - Removed deprecated interface AssetServiceContract
 - Removed deprecated interface HydeKernelContract

packages/framework/src/Concerns/AbstractPage.php

@@ -3,8 +3,8 @@
 namespace Hyde\Framework\Concerns;
 
 use Hyde\Framework\Actions\SourceFileParser;
-use Hyde\Framework\Concerns\FrontMatter\Schemas\PageSchema;
 use Hyde\Framework\Contracts\CompilableContract;
+use Hyde\Framework\Contracts\FrontMatter\PageSchema;
 use Hyde\Framework\Contracts\PageContract;
 use Hyde\Framework\Foundation\PageCollection;
 use Hyde\Framework\Hyde;
@@ -29,9 +29,8 @@
  * @see \Hyde\Framework\Concerns\AbstractMarkdownPage
  * @see \Hyde\Framework\Testing\Feature\AbstractPageTest
  */
-abstract class AbstractPage implements PageContract, CompilableContract
+abstract class AbstractPage implements PageContract, CompilableContract, PageSchema
 {
-    use PageSchema;
     use ConstructsPageSchemas;
 
     public static string $sourceDirectory;
@@ -45,6 +44,10 @@ abstract class AbstractPage implements PageContract, CompilableContract
     public FrontMatter $matter;
     public Metadata $metadata;
 
+    public string $title;
+    public ?array $navigation = null;
+    public ?string $canonicalUrl = null;
+
     public function __construct(string $identifier = '', FrontMatter|array $matter = [])
     {
         $this->identifier = $identifier;

packages/framework/src/Concerns/ConstructsPageSchemas.php

@@ -4,9 +4,8 @@
 
 use Hyde\Framework\Actions\Constructors\FindsNavigationDataForPage;
 use Hyde\Framework\Actions\Constructors\FindsTitleForPage;
-use Hyde\Framework\Concerns\FrontMatter\Schemas\BlogPostSchema;
-use Hyde\Framework\Concerns\FrontMatter\Schemas\DocumentationPageSchema;
-use Hyde\Framework\Concerns\FrontMatter\Schemas\PageSchema;
+use Hyde\Framework\Contracts\FrontMatter\BlogPostSchema;
+use Hyde\Framework\Contracts\FrontMatter\DocumentationPageSchema;
 use Hyde\Framework\Hyde;
 use Hyde\Framework\Models\Author;
 use Hyde\Framework\Models\DateString;
@@ -17,15 +16,13 @@ trait ConstructsPageSchemas
 {
     protected function constructPageSchemas(): void
     {
-        if ($this->usesSchema(PageSchema::class)) {
-            $this->constructPageSchema();
-        }
+        $this->constructPageSchema();
 
-        if ($this->usesSchema(BlogPostSchema::class)) {
+        if ($this instanceof BlogPostSchema) {
             $this->constructBlogPostSchema();
         }
 
-        if ($this->usesSchema(DocumentationPageSchema::class)) {
+        if ($this instanceof DocumentationPageSchema) {
             $this->constructDocumentationPageSchema();
         }
     }
@@ -120,9 +117,4 @@ protected function findPriorityInConfig(): int
         // can be shown first. It's lower than the fallback of 500 so that they
         // still come first. This is all to make it easier to mix priorities.
     }
-
-    protected function usesSchema(string $schema): bool
-    {
-        return in_array($schema, class_uses_recursive($this));
-    }
 }