Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a YAML configuration file #449

Merged
merged 22 commits into from
Aug 28, 2022
Merged

Conversation

caendesilva
Copy link
Member

This file will work as a superset of the site config file, and allow some basic site configuration to be managed with YAML. The YAML options are then be merged taking priority over other settings at runtime using a service provider. This allows for easier static analysis of the configuration file, as well as better interoperability.

@caendesilva caendesilva linked an issue Aug 28, 2022 that may be closed by this pull request
@caendesilva caendesilva marked this pull request as draft August 28, 2022 19:26
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #449 (256f6e3) into master (5896bbd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #449   +/-   ##
=========================================
  Coverage     99.95%   99.95%           
- Complexity      914      924   +10     
=========================================
  Files           106      107    +1     
  Lines          2258     2277   +19     
=========================================
+ Hits           2257     2276   +19     
  Misses            1        1           
Impacted Files Coverage Δ
packages/framework/src/HydeServiceProvider.php 100.00% <100.00%> (ø)
...ramework/src/Services/YamlConfigurationService.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review August 28, 2022 20:26
@caendesilva caendesilva merged commit 74353f0 into master Aug 28, 2022
@caendesilva caendesilva deleted the 441-add-a-yaml-configuration-file branch August 28, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a YAML configuration file
2 participants