Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sitemap generator to use the router #211

Merged
merged 5 commits into from
Jul 10, 2022

Conversation

caendesilva
Copy link
Member

Refactors how the sitemap is generated, by utilizing the router. The actual XML result does not change.

@caendesilva caendesilva linked an issue Jul 10, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #211 (57f0325) into master (33698a6) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #211   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       809       804    -5     
===========================================
  Files            103       103           
  Lines           2075      2065   -10     
===========================================
- Hits            2075      2065   -10     
Impacted Files Coverage Δ
packages/framework/src/Services/SitemapService.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33698a6...57f0325. Read the comment docs.

@caendesilva
Copy link
Member Author

I notice it is much slower (relatively speaking). About 70ms instead of 5ms when running php hyde build:sitemap. But when using php hyde build it's around 7ms which is pretty much exactly the same as the old implementation. The reason for this is that Hyde needs to discover all the routes, which takes a bit. But it only needs to do to one per application lifecycle.

@caendesilva caendesilva merged commit abdf3b1 into master Jul 10, 2022
@caendesilva caendesilva deleted the update-sitemap-generator-to-use-the-router branch July 10, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sitemap generator to use the router
1 participant