Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DiscoveryService.php #208

Merged
merged 1 commit into from
Jul 9, 2022

Conversation

caendesilva
Copy link
Member

The Discovery Service (previously called BuildService) provides helper methods for source file autodiscovery used in the building process to determine where files are located and how to parse them.

Autodiscovery is now powered by the Router. The helpers here can be moved to FluentPathHelpers.php

@codecov
Copy link

codecov bot commented Jul 9, 2022

Codecov Report

Merging #208 (cccb36e) into master (1987d43) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master      #208   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       809       809           
===========================================
  Files            103       103           
  Lines           2075      2075           
===========================================
  Hits            2075      2075           
Impacted Files Coverage Δ
...ckages/framework/src/Services/DiscoveryService.php 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1987d43...cccb36e. Read the comment docs.

@caendesilva caendesilva merged commit 0f3b28d into master Jul 9, 2022
@caendesilva caendesilva deleted the Deprecate-`DiscoveryService.php` branch July 9, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant