Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Router namespaces #205

Merged
merged 8 commits into from
Jul 9, 2022

Conversation

caendesilva
Copy link
Member

Fixes #204

The Router is becoming an integral part of the Hyde core, and does not belong in a support module. Best to bring it into the core package namespace before releasing it.

@caendesilva caendesilva linked an issue Jul 9, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 9, 2022

Codecov Report

Merging #205 (bbe76cc) into master (3c3173e) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master      #205   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       807       807           
===========================================
  Files            103       103           
  Lines           2073      2073           
===========================================
  Hits            2073      2073           
Impacted Files Coverage Δ
...kages/framework/src/Concerns/CanBeInNavigation.php 100.00% <ø> (ø)
packages/framework/src/Contracts/AbstractPage.php 100.00% <ø> (ø)
...ramework/src/Exceptions/RouteNotFoundException.php 100.00% <ø> (ø)
packages/framework/src/Facades/Route.php 100.00% <ø> (ø)
packages/framework/src/Models/NavItem.php 100.00% <ø> (ø)
packages/framework/src/Models/NavigationMenu.php 100.00% <ø> (ø)
packages/framework/src/Models/Route.php 100.00% <ø> (ø)
packages/framework/src/Router.php 100.00% <ø> (ø)
packages/framework/src/Services/BuildService.php 100.00% <ø> (ø)
packages/framework/src/Services/RebuildService.php 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c3173e...bbe76cc. Read the comment docs.

@caendesilva caendesilva merged commit 6437065 into master Jul 9, 2022
@caendesilva caendesilva deleted the 204-go-over-router-namespaces-before-release branch July 9, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go over Router namespaces before release
1 participant