Update the Hyde facade to use a mixin annotation instead of method annotations #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's see if this has gotten better support. If this works, it means that clicking a usage will actually lead to the implementation, and we can get better support for PHPDoc annotations like usages and deprecations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1919 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1766 1766
===========================================
Files 182 182
Lines 4707 4707
===========================================
Hits 4707 4707 ☔ View full report in Codecov by Sentry. |
|
Gonna do some manual testing on VS Code as well. Currently works great in PHPStorm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if this has gotten better support since last time we tried this. If this works, it means that clicking a usage will actually lead to the implementation, and we can get better support for PHPDoc annotations like usages and deprecations.