Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert navigation menu generation to service #187

Merged
merged 83 commits into from
Jul 7, 2022

Conversation

@caendesilva caendesilva linked an issue Jul 5, 2022 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #187 (a856389) into master (21dc056) will decrease coverage by 0.56%.
The diff coverage is 85.18%.

@@              Coverage Diff              @@
##              master     #187      +/-   ##
=============================================
- Coverage     100.00%   99.43%   -0.57%     
- Complexity       789      821      +32     
=============================================
  Files            101      103       +2     
  Lines           2034     2108      +74     
=============================================
+ Hits            2034     2096      +62     
- Misses             0       12      +12     
Impacted Files Coverage Δ
.../framework/src/Actions/GeneratesNavigationMenu.php 100.00% <ø> (ø)
packages/framework/src/Contracts/AbstractPage.php 82.60% <68.42%> (-17.40%) ⬇️
packages/framework/src/Facades/Route.php 100.00% <100.00%> (ø)
packages/framework/src/Models/NavItem.php 100.00% <100.00%> (ø)
...ramework/src/Models/Parsers/MarkdownPageParser.php 100.00% <100.00%> (ø)
...ramework/src/Modules/Navigation/NavigationMenu.php 100.00% <100.00%> (ø)
packages/framework/src/Modules/Routing/Route.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21dc056...a856389. Read the comment docs.

@caendesilva
Copy link
Member Author

Dropping support for automatic linking to readmes in documentation pages. It adds a lot of complexity, and if your docs site doesn't have an index.html page that's gonna cause larger issues with the site.

@caendesilva caendesilva marked this pull request as ready for review July 7, 2022 17:35
@caendesilva caendesilva merged commit 25192c7 into master Jul 7, 2022
@caendesilva caendesilva deleted the create-navigation-menu-generation-service branch July 7, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants