Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RebuildService to use the Router #182

Merged
merged 13 commits into from
Jul 5, 2022

Conversation

caendesilva
Copy link
Member

No description provided.

@caendesilva caendesilva linked an issue Jul 5, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #182 (e70e4a7) into master (8f24fae) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #182   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       779       781    +2     
===========================================
  Files            100       100           
  Lines           2021      2018    -3     
===========================================
- Hits            2021      2018    -3     
Impacted Files Coverage Δ
...ckages/framework/src/Services/DiscoveryService.php 100.00% <ø> (ø)
packages/framework/src/Modules/Routing/Route.php 100.00% <100.00%> (ø)
packages/framework/src/Services/RebuildService.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f24fae...e70e4a7. Read the comment docs.

@caendesilva caendesilva merged commit bd543bd into master Jul 5, 2022
@caendesilva caendesilva deleted the refactor-rebuild-service-to-use-the-router branch July 5, 2022 06:07
@caendesilva caendesilva mentioned this pull request Jul 5, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the rebuild service to use the router
2 participants