Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Hyde URL helper to not modify already qualified URLs #1757

Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jun 29, 2024

This is implemented in the Hyperlinks class meaning it effects both the Hyde::url() helper and the global url() function.

Hyde::url('https://example.com/foo');

// Before https://example.com/https://example.com/foo
// After https://example.com/foo

@caendesilva caendesilva force-pushed the update-url-helper-to-not-modify-already-qualified-urls branch from 912b4d2 to c886063 Compare June 29, 2024 07:26
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (a2dfeb8) to head (4b46ce7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1757   +/-   ##
=========================================
  Coverage     99.95%   99.95%           
- Complexity     1749     1750    +1     
=========================================
  Files           181      181           
  Lines          4673     4675    +2     
=========================================
+ Hits           4671     4673    +2     
  Misses            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva marked this pull request as ready for review June 29, 2024 07:28
@caendesilva caendesilva merged commit 44678c2 into master Jun 29, 2024
21 checks passed
@caendesilva caendesilva deleted the update-url-helper-to-not-modify-already-qualified-urls branch June 29, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant