Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path property in Image model should be relative to media directory #359

Closed
caendesilva opened this issue Aug 7, 2022 · 2 comments · Fixed by #375
Closed

Path property in Image model should be relative to media directory #359

caendesilva opened this issue Aug 7, 2022 · 2 comments · Fixed by #375
Assignees
@caendesilva

Comments

@caendesilva
Copy link
Member

No description provided.

@caendesilva
Copy link
Member Author

This bubbles to the og:image property, which should also be resolved relatively:

// expected
'<meta property="og:image" content="../media/image.jpg">',
// actual
'<meta property="og:image" content="media/image.jpg">',

@caendesilva
Copy link
Member Author

caendesilva commented Aug 8, 2022 •
edited
Loading

This bubbles to the og:image property, which should also be resolved relatively:

// expected
'<meta property="og:image" content="../media/image.jpg">',
// actual
'<meta property="og:image" content="media/image.jpg">',

Same issue with itemprops, <meta itemprop="url" content="image.jpg">

@caendesilva caendesilva self-assigned this Aug 8, 2022
This was referenced Aug 8, 2022
Closed
Merged
@caendesilva caendesilva linked a pull request Aug 8, 2022 that will close this issue
Consistently use image paths relative to _media directory as described in the documentation #375
Merged
3 tasks
caendesilva added a commit that referenced this issue Aug 8, 2022
@caendesilva
Fix #359 on this end too
a271e5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caendesilva caendesilva

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@caendesilva