Refactor self-update command code to extract internal helper classes #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
changed the title
caendesilva
added
the
halt-matrix-tests
caendesilva
force-pushed
the
internal-code-refactor
branch
from
86df40d to
b79ddda
Compare
caendesilva
removed
the
halt-matrix-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves code quality and confidence by extracting typed interfaces. These are internal as to not increase the maintenance burden. I am not that concerned about the extra boilerplate lines because the binary file size increase is comparatively minimal relative to the included vendor code we also bundle and that we don't fully use.