long paths support and other minor improvements #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turns out that .net 4.6.2 just replaces some PathTooLongException with DirectoryNotFoundException
…sure about the move to recycle bin)
tunisiano187
approved these changes
Jul 11, 2020
|
Wow! Thank you very much for all those improvements, looks really great on the first look. And the AlphaFS library looks also like a very promising alternative to the build in IO library. And didn't know about it before. I will test the changes in the next time and try to finally release an update after a long time of inactivity 🙈 |
|
@tunisiano187 Thanks for reviewing the changes! |
I use it all the time, for the record. Very useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have been using RED2 for a while to cleanup our mess, wanted to share back some of the improvements I've made
here's an extended explanation of the commits included in this PR:
long paths support: upgraded project to .net 4.6.2 and added manifest file to support paths longer than 260 characters
fix crash due to case sensitivity of paths: fixes crash that happens when crawling if the user enters \server\sharedfolder instead of \server\SharedFolder
speed up crawl and deletion by disabling UI updates: when there are a lot of empty folders, the UI freezes and slows down the crawl because it gets updated too frequently
added Mac "junk" files to default ignore list: a couple extra patterns, for the Mac equivalent of the Thumbs.db files on windows
allow opening the selected folder after canceling the crawl or after deleting: (in the context menu that shows up when right clicking on a folder)