Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent the use of empty user, service, or target names #87

Merged
merged 6 commits into from
Jul 3, 2022
Merged

Prevent the use of empty user, service, or target names #87

merged 6 commits into from
Jul 3, 2022

Commits on Jul 1, 2022

  1. Update use of clap to version 3.2

    @brotskydotcom
    brotskydotcom committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    5918d67 View commit details
    Browse the repository at this point in the history

  2. Don't allow empty strings to name credentials. 

    Fixes hwchen#86.

The fix, since we can't fail to create entries without modifying the API, is to make sure the created entries with empty strings can't be used to set or get passwords.  We do this by introducing an "always invalid" platform credential that we create for these entries.

Updates docs to clarify that the service and user names must be non-empty.
    @brotskydotcom
    brotskydotcom committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    a95b8a8 View commit details
    Browse the repository at this point in the history

  3. Bump the patch version number. 

    This reflects the fix of hwchen#86.
    @brotskydotcom
    brotskydotcom committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    89e44f6 View commit details
    Browse the repository at this point in the history

  4. Fix rustfmt errors.

    @brotskydotcom
    brotskydotcom committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    adddf59 View commit details
    Browse the repository at this point in the history

  5. Fix windows clippy errors. 

    Also test on Windows.
    @brotskydotcom
    brotskydotcom committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    31c4658 View commit details
    Browse the repository at this point in the history

  6. Improve docs, bump minor version number. 

    Based on review discussion, this change should really be considered a minor version change rather than a patch release.

The docs have been updated to note the change in behavior and the workaround available to anyone who was relying on the prior behavior.  In addition, a warning has been issued that the next major release may change the `Entry` creation API to be fallible.
    @brotskydotcom
    brotskydotcom committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    f8b5074 View commit details
    Browse the repository at this point in the history