-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to globalization #67
Conversation
I think this change is good. Moving these strings to a different resource file would remove codegen for them as well. The strings are only used in the manifest and not in code so I think it's safe. Thank you. There are reports that file association icons are causing slowdown for some users. I will take care of them and move them to another folder. |
Yes, easier to handle.
Pretty sure it's not related to that but tbh not entirely happy with the icons, at least on 150 scale the 32px video downscales really bad. On this weekend I'll see what I can do. |
I suspect that icon is being dynamically downscaled. Since 32 at 100% is still quite legible. See #68 for more icon sizes that I have generated. Anything below 32px is going to be the simple icon. |
yeah. I did a quick check for List View, so it goes something like this:
|
Native applications don't use 26 and 28. How did you verify this? |
just changed the scale, log off, log in, open explorer. and yes nobody uses 26 or 28, all downscaled the 32 pixel, my guess 175 is rarely used is it worth it to make them? don't think so |
That's fine. Thank you for verifying. We will stick with what native applications use. They are: 128, 129, 16, 20, 24, 256, 30, 32, 336, 36, 40, 48, 60, 63, 64, 72, 80, 96 See #68 for more details. With 5 main variations. The rest are scaled versions of these 5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We can merge once you resolve the typo.
Moved manifest strings to another resource file for better organization, should help with localization.
Also added some strings (eg. "AppShortName", "AppDisplayName") for other writing systems.
ToDo