Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor editorconfig update #563

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

United600
Copy link
Collaborator

Some minor updates and, adds the dotnet_sort_system_directives_first = true and csharp_indent_case_contents_when_block = false configs.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. format request labels Feb 12, 2025
@huynhsontung
Copy link
Owner

Setting dotnet_sort_system_directives_first = true now may make a lot of files need to be reformatted.

@United600
Copy link
Collaborator Author

Setting dotnet_sort_system_directives_first = true now may make a lot of files need to be reformatted.

True, if not almost all. I saw that it was the set on the runtime repository and that it is recommended.

@huynhsontung
Copy link
Owner

The default value for this was true as well. Not sure how it was set to false. https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/dotnet-formatting-options#dotnet_sort_system_directives_first

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 21, 2025
@United600
Copy link
Collaborator Author

The default value for this was true as well. Not sure how it was set to false. https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/dotnet-formatting-options#dotnet_sort_system_directives_first

Maybe it's a relatively new setting that it isn't automatically applied on some projects (like Net Native)?

@huynhsontung huynhsontung merged commit d0dfaaa into huynhsontung:main Feb 23, 2025
4 checks passed
@United600 United600 deleted the editorconfig branch February 24, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants