Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add customizable application theme #542

Merged
merged 6 commits into from
Feb 9, 2025

Conversation

SKure27
Copy link
Contributor

@SKure27 SKure27 commented Jan 19, 2025

Added a drop down menu on the settings page which allows you to switch the app theme between light, dark, and auto (default).

This is my first time using visual studio as well as working on a UWP app. I could see there was a lot of generated code but wasn't sure what the official way to add to the ui was so I just made changes manually.

It would be nice if the feature could be copied into the actual app (just implemented better then how I did it).

SKure27 and others added 3 commits January 19, 2025 02:53
…h the app theme between light, dark, and auto (default).

This is my first time using visual studio as well as working on a UWP app. I could see there was a lot of generated code but wasn't sure what the official way to add to the ui was so I just made changes manually.

It would be nice if the feature could be copied into the actual app (just implemented better then how I did it).
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 9, 2025
@huynhsontung huynhsontung changed the title Added theme select menu in settings feat: add customizable application theme Feb 9, 2025
Copy link
Owner

@huynhsontung huynhsontung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and refactored your changes to better align with our structure.

image

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 9, 2025
@huynhsontung huynhsontung enabled auto-merge (squash) February 9, 2025 05:43
@huynhsontung huynhsontung merged commit c00fecc into huynhsontung:main Feb 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants