Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add media type disabled icons #522

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

United600
Copy link
Collaborator

@United600 United600 commented Dec 28, 2024

  • Adds audio off and movies off glyph
  • Adds new icon ResourceDictionary
  • Changes more icons to use our custom font family
  • Changes PlaylistView selection command bar remove glyph to match the one used on flyouts

add build font instructions
change remove action icon to cancel icon
@United600 United600 marked this pull request as ready for review January 4, 2025 14:27
@huynhsontung
Copy link
Owner

Just to confirm, the new icon dictionary is just for custom icon resources, right? Fluent icons are still left as-is?

@United600
Copy link
Collaborator Author

Just to confirm, the new icon dictionary is just for custom icon resources, right? Fluent icons are still left as-is?

Yes, at this point, I've only added the custom icon resources, since the code points (some) are harder to check compared to the system symbol font.
Do you want to add every icon in use?

@huynhsontung
Copy link
Owner

No, that won't be necessary. I just want to clarify the intention for the font dictionary.

@huynhsontung huynhsontung merged commit f622247 into huynhsontung:main Jan 6, 2025
4 checks passed
@United600 United600 deleted the font branch January 6, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants