Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: minor layout and light theme improvements #477

Merged
merged 13 commits into from
Nov 26, 2024
Merged

style: minor layout and light theme improvements #477

merged 13 commits into from
Nov 26, 2024

Conversation

United600
Copy link
Collaborator

@United600 United600 commented Nov 2, 2024 •
edited
Loading

  • Improve the CoverArt brush stroke for better visibility on a light theme
  • Fix the pressed text brush of AddSubtitle button for the light theme during video playback
  • Improve SelectionCommandRow background brush for the light theme
  • Adjust the vertical position and size of the PaneSearch icon for the compact visual state
  • Minor improvement to the group header style
  • Streamline the play button on MediaListViewItem and adjust a few margins
  • Improve the gamepad navigation of the Settings page
  • Decrease the step interval of the timing offset sliders to improve precision
  • Adjust and reorganize some implicit animations
  • Fixes Top shadow has margin from top of the screen in full screen mode #478

@United600
change cover art border brush
762ff10
@United600
minor change to group header style
362f920 
change custom brush names and improve comments
@United600
improve nav view and split button custom behavior
45807d5
@United600
improve media listview item control
3e0102d
@United600
improve settings gamepad navigation
000c653 
change multiple instances setting icon
@United600
lower timing sliders step frequency
f69d2ba 
rename volume toggle button style property
@United600
move custom flyout style
4c0ce8a 
minor improvement to audio subtitle flyout
@United600
fix header gradient gap on full screen
ad1e64a
@United600
increase header background height
ea54005 
adjust background acrylic light mode tint opacity
@United600
tweak couple of implicit animations
9e02f2b 
change subtle button high contrast brushes
@United600
change selection command row brush
786347a 
fix track number opacity on active state
@United600 United600 changed the title style: minor improvements to light theme style: minor layout and light theme improvements Nov 11, 2024
huynhsontung
huynhsontung approved these changes Nov 26, 2024
View reviewed changes
Copy link
Owner

@huynhsontung huynhsontung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Perfect PR. No edit. 👍

@huynhsontung huynhsontung merged commit e0fcff1 into huynhsontung:main Nov 26, 2024
4 checks passed
@United600 United600 deleted the styles branch December 7, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huynhsontung huynhsontung huynhsontung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Top shadow has margin from top of the screen in full screen mode
2 participants
@United600 @huynhsontung