style: minor UI fixes #464
Conversation
| <XamlUICommand | ||
| x:Key="PlayCommand" | ||
| Command="{x:Bind ViewModel.PlayCommand}" | ||
| IconSource="{ui:SymbolIconSource Symbol=Play}" | ||
| Label="{strings:Resources Key=Play}" /> | ||
|
|
||
| <XamlUICommand | ||
| x:Key="PlayNextCommand" | ||
| Command="{x:Bind ViewModel.PlayNextCommand}" | ||
| IconSource="{ui:FontIconSource FontFamily={StaticResource ScreenboxSymbolThemeFontFamily}, | ||
| Glyph=}" | ||
| Label="{strings:Resources Key=PlayNext}" /> | ||
|
|
||
| <XamlUICommand | ||
| x:Key="RemoveCommand" | ||
| Command="{x:Bind ViewModel.RemoveCommand}" | ||
| IconSource="{ui:SymbolIconSource Symbol=Clear}" | ||
| Label="{strings:Resources Key=Remove}" /> | ||
|
|
||
| <XamlUICommand | ||
| x:Key="PropertiesCommand" | ||
| Command="{StaticResource ShowPropertiesCommand}" | ||
| IconSource="{ui:FontIconSource Glyph=}" | ||
| Label="{strings:Resources Key=Properties}" /> |
There was a problem hiding this comment.
To give some context, the XamlUICommands are there to be shared between context menu items and future command bar buttons, like the inbox media player. It's fine to remove these for now.
There was a problem hiding this comment.
Didn't knew that, but wouldn't it be better for sharing to simply extract the entire MenuFlyout?
There was a problem hiding this comment.
What do you mean by extracting the entire menu Flyout? XamlUICommand includes command, icon, label, and keyboard accelerator. Having controls share the same XamlUICommand will ensure they behave the same, functionally and aesthetically.
There was a problem hiding this comment.
I'm confused. How would you map these MenuFlyoutItems into Buttons or AppBarButtons?
There was a problem hiding this comment.
Oh maybe this? There must be a way
| <XamlUICommand | ||
| x:Key="PlayCommand" | ||
| Command="{x:Bind ViewModel.PlayCommand}" | ||
| IconSource="{ui:SymbolIconSource Symbol=Play}" | ||
| Label="{strings:Resources Key=Play}" /> | ||
|
|
||
| <XamlUICommand | ||
| x:Key="PlayNextCommand" | ||
| Command="{x:Bind ViewModel.PlayNextCommand}" | ||
| IconSource="{ui:FontIconSource FontFamily={StaticResource ScreenboxSymbolThemeFontFamily}, | ||
| Glyph=}" | ||
| Label="{strings:Resources Key=PlayNext}" /> | ||
|
|
||
| <XamlUICommand | ||
| x:Key="PropertiesCommand" | ||
| Command="{StaticResource ShowPropertiesCommand}" | ||
| IconSource="{ui:FontIconSource Glyph=}" | ||
| Label="{strings:Resources Key=Properties}" /> |
There was a problem hiding this comment.
Same context as the MainPage
Screenbox/App.xaml
Outdated
| <StaticResource x:Key="AccentFillColorCustomBrush" ResourceKey="SystemAccentColorLight2" /> | ||
| <StaticResource x:Key="AccentFillColorCustomBrush" ResourceKey="SystemAccentColorLight3" /> | ||
| </ResourceDictionary> | ||
| <ResourceDictionary x:Key="Light"> | ||
| <StaticResource x:Key="AccentFillColorCustomBrush" ResourceKey="SystemAccentColorDark1" /> | ||
| <StaticResource x:Key="AccentFillColorCustomBrush" ResourceKey="SystemAccentColorDark2" /> |
There was a problem hiding this comment.
This resource only applies to Animated icons and thus causes color mismatch
There was a problem hiding this comment.
I will be reverting this so I can merge this PR. Please feel free to submit this change again in another PR.
AppTitleBartitle inactive brush on theme switchingPlayerPageHeaderandPlayerControlsbackground for the light themeXamlUICommandShuffleAndPlaybutton in theArtistsPageminimal visual stateBreadcrumbBarandNoNetworkDrivePanelonNetworkPageScrollViewer.Is*ScrollChainingEnabledtoSemanticZoomcontrol according to the documentation