l10n: create dedicated strings for music and video libraries #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The translation of "Music" in some languages doesn't convey the music library in context. Create a dedicated string to accomodate for these differences
huynhsontung
force-pushed
the
l10n-media-library-strings
branch
from
49ef73c to
d940883
Compare
|
@huynhsontung The way you did it was very good, I believe you can cancel the reversion as it is correct with our language. |
|
@maisondasilva Just to confirm, you meant this commit is not correct? Should the text on the nav bar and music page title be the same? I was guessing based on the inbox Media Player app.
|
|
@huynhsontung Yes, the 3 variables are correct as you did, my question is about this The image above is in pt-PT (Portugal) although it follows the same standard as pt-BR (Brazil) |
|
This commit is 100% correct Same for Video Thanks Maison |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #457
The translation of "Music" in some languages doesn't convey the music library in context. Create a dedicated string to accommodate for these differences