Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve screen reader support and general accessibility #455

Merged
merged 11 commits into from
Oct 7, 2024

Conversation

United600
Copy link
Collaborator

@United600 United600 commented Sep 28, 2024

Settings page

Main page

  • Add keyboard shortcuts to navigation view items

Playlist page

  • Improve selection command bar
  • Add dismiss shortcut to command bar
  • Improve narrator support
  • Add select all shortcut

Player

  • Improve narrator support
  • Adjust some paddings and sizes
  • Adjust Audio Visual selector position and design

add settings item footer style

remove item cards corner radius
update notices document
add select all shortcut

add selection related strings

improve action buttons narrator
adjust some paddings and sizes

add volume slider tooltip string
@United600 United600 force-pushed the a11y branch 2 times, most recently from 268179e to 1ea6c2f Compare October 2, 2024 15:49
add search box tooltip

update keyboard resources comments
huynhsontung and others added 2 commits October 2, 2024 21:09
add audio visual icon

add a couple of strings and copywriting
Screenbox/Controls/SeekBar.xaml.cs Outdated Show resolved Hide resolved
Comment on lines +294 to +304
<Button
x:Name="LivelyOptionsButton"
Grid.Column="4"
Width="44"
Height="44"
Margin="4,6,4,2"
Padding="0"
VerticalAlignment="Top"
AutomationProperties.Name="{x:Bind LivelyOptionsButton.(ToolTipService.ToolTip)}"
Style="{StaticResource SubtleButtonStyle}"
ToolTipService.ToolTip="{strings:Resources Key=VisualizerOptionsToolTip}">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now in narrow window sizes, the buttons take up too much real estate. Should we consider resizing the buttons to the standard button size for this layout?

ApplicationFrameHost_dP7QjUhLU5

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really an issue but we probably should consider removing the title bar right padding when in fullscreen as well, now that we have a button there.

msedge_abSWyTwdi7

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now in narrow window sizes, the buttons take up too much real estate. Should we consider resizing the buttons to the standard button size for this layout?

Personally I think we should slightly reduce it in all layouts, or consider alternatives

Not really an issue but we probably should consider removing the title bar right padding when in fullscreen as well, now that we have a button there.

AFAIK we can't since it's reserved

imagem

Screenbox/Pages/PlayerPage.xaml Outdated Show resolved Hide resolved
Screenbox/Pages/PlayerPage.xaml Outdated Show resolved Hide resolved
Screenbox/Pages/PlayerPage.xaml Outdated Show resolved Hide resolved
Screenbox/Pages/PlayerPage.xaml Show resolved Hide resolved
Screenbox/Pages/SettingsPage.xaml Show resolved Hide resolved
Screenbox/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved
Screenbox/Strings/en-US/Resources.resw Show resolved Hide resolved
Screenbox/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved
Screenbox/Pages/PlayerPage.xaml Outdated Show resolved Hide resolved
Screenbox/Pages/PlayerPage.xaml Outdated Show resolved Hide resolved
@huynhsontung huynhsontung merged commit 50e0ff2 into huynhsontung:main Oct 7, 2024
4 checks passed
@United600 United600 deleted the a11y branch October 7, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants