- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve screen reader support and general accessibility #455
Conversation
add settings item footer style remove item cards corner radius
update notices document
add select all shortcut add selection related strings improve action buttons narrator
adjust some paddings and sizes add volume slider tooltip string
268179e
to
1ea6c2f
Compare
add search box tooltip update keyboard resources comments
add audio visual icon add a couple of strings and copywriting
<Button | ||
x:Name="LivelyOptionsButton" | ||
Grid.Column="4" | ||
Width="44" | ||
Height="44" | ||
Margin="4,6,4,2" | ||
Padding="0" | ||
VerticalAlignment="Top" | ||
AutomationProperties.Name="{x:Bind LivelyOptionsButton.(ToolTipService.ToolTip)}" | ||
Style="{StaticResource SubtleButtonStyle}" | ||
ToolTipService.ToolTip="{strings:Resources Key=VisualizerOptionsToolTip}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now in narrow window sizes, the buttons take up too much real estate. Should we consider resizing the buttons to the standard button size for this layout?
Personally I think we should slightly reduce it in all layouts, or consider alternatives
Not really an issue but we probably should consider removing the title bar right padding when in fullscreen as well, now that we have a button there.
AFAIK we can't since it's reserved
Settings page
Audio Visual
expander gamepad navigationAudio Visual
iconMain page
Playlist page
Player
Audio Visual
selector position and design