Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unintended UI flipping in RTL languages #434

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

huynhsontung
Copy link
Owner

@huynhsontung huynhsontung commented Aug 27, 2024

Enforce LTR and RTL flow in specific UI elements. Fixes #429

image

image

image

image

enforce LTR and RTL flow in specific UI elements
@huynhsontung huynhsontung merged commit 9eb3400 into main Aug 27, 2024
4 checks passed
@huynhsontung huynhsontung deleted the fix-rtl-layout branch August 27, 2024 15:11
@Y-PLONI
Copy link

Y-PLONI commented Aug 31, 2024

@huynhsontung
What about Windows Store?
Do you have a way to enforce LTR or vice versa - RTL?
I don't know what the problem is, but right now the text in the Windows Store is displayed incorrectly.
I started to reverse it in Crowdin but it's a bit complicated...

@huynhsontung
Copy link
Owner Author

@Y-PLONI Does it still look reversed on the Store? It looks correct from my Store dashboard. Please avoid reversing the text in Crowdin. The translation should be independent of how the text should be displayed.

image

@Y-PLONI
Copy link

Y-PLONI commented Sep 3, 2024

Looks great! Thank you very much!
I took care of the translation, now it is in the true and correct order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unintended UI flipping in right-to-left languages
2 participants