Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve keyboard accessibility navigation #396

Merged
merged 10 commits into from
Sep 8, 2024

Conversation

United600
Copy link
Collaborator

@United600 United600 commented Jul 1, 2024

  • Add more access keys
  • Improve the SplitButton behavior (Tooltips and AutomationProperties)
  • Add NavigationView keyboard behavior (Improves the keyboard interaction on the built-in buttons)
  • Disable PaneAutoSuggestButton IsTextScaleFactorEnabled
  • Add localization support for access keys
  • Add Search shortcut

Checklist

  • On fullscreen, pressing the Alt key should toggle the PlayerControls visibility
  • Sliders exhibit focus trapping
  • KeyTip placement for the AutoSuggestBox can be inconsistent after the flyout is opened
  • Support KeyboarAccelerators localization

Probably should add some documentation, or improve the resource comments clarity (as concisely as possible), to help the localization efforts. Maybe adding links to this page section or this section.

@United600 United600 marked this pull request as ready for review August 27, 2024 17:19
@huynhsontung huynhsontung merged commit 527ea35 into huynhsontung:main Sep 8, 2024
2 checks passed
@United600 United600 deleted the access-keys branch September 8, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants