chore: fix Python 3.8 compatibility issue

huxuan · Mar 6, 2024 · adfc430 · adfc430
1 parent 5cb20df
commit adfc430
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 1 deletion.
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
@@ -22,7 +22,7 @@ ENV PIPX_DEFAULT_PYTHON=/usr/local/bin/python
 RUN pipx install pdm==2.12.4
 
 # Install pre-commit
-RUN pipx install pre-commit==3.6.2
+RUN pipx install pre-commit==3.5.0
 
 # Create a non-root user with sudo permission
 ARG USERNAME=ss-python

diff --git a/.renovaterc.json b/.renovaterc.json
@@ -49,6 +49,12 @@
                 ]
             },
             "semanticCommitScope": "copier-template"
+        },
+        {
+            "enabled": false,
+            "matchPackageNames": [
+                "pre-commit"
+            ]
         }
     ]
 }
diff --git a/template/.devcontainer/Dockerfile.jinja b/template/.devcontainer/Dockerfile.jinja
@@ -1,3 +1,4 @@
+[% from pathjoin("includes", "version_compare.jinja") import version_higher_than -%]
 ARG PYTHON_VERSION={{ default_py }}
 
 ########################################################################################
@@ -22,7 +23,11 @@ ENV PIPX_DEFAULT_PYTHON=/usr/local/bin/python
 RUN pipx install pdm==2.12.4
 
 # Install pre-commit
+[%- if not version_higher_than(min_py, "3.9") %]
+RUN pipx install pre-commit==3.5.0
+[%- else %]
 RUN pipx install pre-commit==3.6.2
+[%- endif %]
 
 # Create a non-root user with sudo permission
 ARG USERNAME={{ repo_name }}

diff --git a/template/.renovaterc.json.jinja b/template/.renovaterc.json.jinja
@@ -1,3 +1,4 @@
+[% from pathjoin("includes", "version_compare.jinja") import version_higher_than -%]
 {
     "$schema": "https://docs.renovatebot.com/renovate-schema.json",
     "customManagers": [
@@ -54,5 +55,14 @@
             },
             "semanticCommitScope": "copier-template"
         }
+[%- if not version_higher_than(min_py, "3.9") %],
+        {
+            "enabled": false,
+            "matchCurrentVersion": "3.5.0",
+            "matchPackageNames": [
+                "pre-commit"
+            ]
+        }
+[%- endif %]
     ]
 }