Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable package-lock.json #95

Closed
wants to merge 1 commit into from
Closed

Conversation

LitoMore
Copy link
Contributor

Since we ignored package-lock.json in .gitignore. Then we should turn off the lock file in .npmrc as well.

@hustcc
Copy link
Owner

hustcc commented May 6, 2022

maybe ignored by

"files": [
"CHANGELOG.md",
"lib/",
"types/"
],

@LitoMore
Copy link
Contributor Author

LitoMore commented May 6, 2022

But it will be generated locally. We should disable it.

@hustcc
Copy link
Owner

hustcc commented May 6, 2022

The repo do not care the local development env.

@LitoMore
Copy link
Contributor Author

LitoMore commented May 7, 2022

You should. For example the CI problem of #91, you won't notice the CI problem on your local. That's because you have a lockfile locally, which is inconsistent with the CI environment.

@hustcc
Copy link
Owner

hustcc commented Oct 21, 2022

loca

@hustcc hustcc closed this Oct 21, 2022
@LitoMore LitoMore deleted the add-npmrc branch October 21, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants