Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-canvas-mock): account for possible TypeError #116

Conversation

virtuoushub
Copy link
Contributor

closes #115

@hustcc
Copy link
Owner

hustcc commented Jun 26, 2023

@virtuoushub hello, help to update the version? thanks.

@virtuoushub
Copy link
Contributor Author

#115

Hi @hustcc, is the ask if this should be a patch/minor/major? I think just a patch as it fixes a bug.


If the ask is for a summary of these changes, #115 has all the details surrounding the bug these changes attempt to fix.

The gist of the changes in this PR is that they bring back the old logic from before #100 for those cases where the window object is not what the test framework expects; but also allow for #100 to work as expected if the window object does contain the expected properties.

@hustcc
Copy link
Owner

hustcc commented Jun 27, 2023

Only update package.version = 2.5.2.

@hustcc hustcc merged commit dc35dbc into hustcc:master Jun 28, 2023
3 checks passed
@hustcc
Copy link
Owner

hustcc commented Jun 28, 2023

  • jest-canvas-mock@2.5.2

@virtuoushub virtuoushub deleted the fix/jest-canvas-mock/account-for-possible-type-error branch July 2, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new mockPrototype(win) implementation can cause TypeError
2 participants