Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on nightly. #4

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Fix on nightly. #4

merged 1 commit into from
Oct 2, 2017

Conversation

clarfonthey
Copy link
Collaborator

@clarfonthey clarfonthey commented Apr 30, 2017

This avoids conflict with the new from_bits method that was added on nightly by calling the trait's method directly.

Fixes #2.

@autohuonw
Copy link
Collaborator

Thanks for the pull request, and welcome! You should hear from @huonw (or someone else) soon.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 99.237% when pulling c9cf15a on clarcharr:master into d01ee22 on huonw:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 99.237% when pulling c9cf15a on clarcharr:master into d01ee22 on huonw:master.

@clarfonthey
Copy link
Collaborator Author

@huonw ping

@clarfonthey
Copy link
Collaborator Author

@huonw ping again

@onelson
Copy link

onelson commented Jun 26, 2017

Looking at rust-lang/rust#40470 it looks like this is up to maintainers to address on their end. PR looks to be working for me!

@adam-azarchs
Copy link

Now that 1.18.0 has been released this is needed in stable, not just beta.

@clarfonthey
Copy link
Collaborator Author

@huonw are you going to merge this?

@clarfonthey clarfonthey assigned clarfonthey and unassigned huonw Sep 6, 2017
@clarfonthey clarfonthey merged commit 83062b2 into huonw:master Oct 2, 2017
@Bobo1239
Copy link

Bobo1239 commented Oct 11, 2017

@clarcharr You don't happen to have publish permissions for crates.io, do you? Would love to remove the git dependency from my project.

@clarfonthey
Copy link
Collaborator Author

I don't remember but I will try to remember to check tomorrow!

@Bobo1239
Copy link

@clarcharr Friendly reminder :)

@clarfonthey
Copy link
Collaborator Author

I do not have the permissions! :(

You'd have to have @huonw do it. Although IMHO it may just be better to fork this crate and release it as something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants