Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert remove prompt + expose ARN as properties for ELBs for further usage #2

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Revert remove prompt + expose ARN as properties for ELBs for further usage #2

merged 3 commits into from
Feb 28, 2023

Conversation

andreadecorte
Copy link
Collaborator

@andreadecorte andreadecorte commented Feb 27, 2023 •
edited
Loading

  1. Revert prompts as we can just use the Force parameters
  2. Expose ARN in ELB (this will be upstreamed too). This will be used to be able to tag resources
  3. Expose HostedZOne ID for tagging purposes

@andreadecorte
Copy link
Collaborator Author

pushed upstream with rebuy-de#947 (structure changed, we can sync later)

@hunterkepley
Copy link
Owner

/lgtm

@hunterkepley hunterkepley merged commit 7436928 into hunterkepley:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreadecorte @hunterkepley