Recreated the Kong navigation clone using reactjs #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mehrab-alam
commented
Mar 20, 2023
•
mehrab-alam
commented
amezng
requested changes
Mar 27, 2023
marketing/src/index.js
Outdated
|
|
||
| const root = ReactDOM.createRoot(document.getElementById("root")); | ||
| root.render( | ||
| <React.StrictMode> | ||
|
|
||
| <KongNav /> |
| @@ -0,0 +1,77 @@ | |||
| .products-menu-option { | |||
| font-size: 0.8rem; | ||
| } | ||
|
|
||
| .menu-container { |
amezng
requested changes
Mar 29, 2023
| </li> | ||
|
|
||
| <li className="kong-sub-link-list sub-list-2">Solution</li> | ||
| <li className="kong-sub-link-list sub-list-3">Customers</li> |
There was a problem hiding this comment.
Not required to create or use such classnames
amezng
requested changes
Mar 29, 2023
| {isOpen && (<KongNavMenu />)} | ||
| </div> | ||
| </li> | ||
| <li className="kongnav-menu-2">Solution</li> |
There was a problem hiding this comment.
Use the class kongnav-menu-item
| <ul> | ||
| <li> | ||
| <div className="menu-description"> | ||
| <a href="">Kong Enterprise</a> |
There was a problem hiding this comment.
Use array of objects for rendering all the menu items
|
not as per the design |
|
@mehrab-alam there should be more space between |
|
Its still the same as per the design. There is extra space in mobile nav. Fix it |
|
It still shows the same old image. Can you update the latest images. |
|
It still the same issue
|
|
Rename the BlueSimple file and fix index.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.