Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Adds case-sensitive trading pairs handling for Dexalot #80

Merged

Conversation

petioptrv
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

This PR adds handling of case-sensitive trading pairs to the Dexalot connector.

Tests performed by the developer:

  • Adapted the unit tests to catch this issue in the future.
  • Manually tested the bot using BTC.B-USDC (exchange pair BTC.b/USDC).

Tips for QA testing:

Please ensure that case sensitive trading pairs don't cause problems for the bot.

@cardosofede cardosofede requested a review from fengtality March 30, 2023 03:43
@rapcmia rapcmia requested review from nikspz and rapcmia March 30, 2023 04:56
@nikspz
Copy link
Contributor

nikspz commented Mar 30, 2023

hi @petioptrv

Tests performed:

  • Clone and install development + gatewayPR80
  • start the bot and gatewayPR80
  • add balance for BTC.b and WETH.e
  • added gateway connector-tokens dexalot_avalanche_dexalot BTC.B,WETH.E
  • checked that bot shows correct balance for WETH.E and incorrect for BTC.B
  • created pureMM startegy using BTC.B-USDC and WETH.E-USDC
  • review that bot do not placed the orders for BTC.B-USDC and also for WETH.E-USDC Pair

Currently there're issues on the PR

  1. Bot Not displayed BTC.B balance using Client and also using
  2. endpoint does not display also used {BTC.b, BTC.B} but still its showing 0.000000
  3. Bot Doesn't place orders using BTC.B-USDC market
  4. Bot Doesn't place orders using WETH.E-USDC market

1.)
Steps to reproduce:

  • add/swap to have BTC.b balance on the exchange
  • check balance on the client
  • Pay attention to BTC.B balance on the Client

image

2.)
Same thing using endpoints
image

3.)
BTC.B-USDC market bot failed to place orders

image

4.)
WETH.E-USDC market bot failed to place orders

image

@petioptrv
Copy link
Contributor Author

petioptrv commented Mar 31, 2023

@nikspz, thank you for testing. I have pushed a fix for the balance issue observed here in the last commit (ed335b2). The order placement issue is due to a problem in the trading rules parsing, and I've added a fix for that on the client side in this PR.

nikspz
nikspz previously approved these changes Mar 31, 2023
Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests performed:

  • Clone and install PR 6191+ gatewayPR80
  • start the bot and gatewayPR80
  • add balance for BTC.b and WETH.e
  • added gateway connector-tokens dexalot_avalanche_dexalot BTC.B,WETH.E
  • checked that bot shows correct balance for WETH.E and for BTC.B
  • created pureMM/amm_arb startegy using BTC.B-USDC and WETH.E-USDC
  • review that bot placed the orders for BTC.B-USDC, WETH.E-USDC and AVAX-USDC Pair

@nikspz nikspz self-requested a review March 31, 2023 09:47
@nikspz nikspz dismissed their stale review March 31, 2023 09:47

retest latest commit

Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests performed:

  • Clone and install PR 6191+ gatewayPR80
  • start the bot and gatewayPR80
  • add balance for BTC.b and WETH.e
  • added gateway connector-tokens dexalot_avalanche_dexalot BTC.B,WETH.E
  • checked that bot shows correct balance for WETH.E and for BTC.B
  • created pureMM/amm_arb startegy using BTC.B-USDC and WETH.E-USDC
  • review that bot placed the orders for BTC.B-USDC, WETH.E-USDC and AVAX-USDC Pair

@fengtality fengtality merged commit dc55d62 into hummingbot:development Mar 31, 2023
@fengtality fengtality deleted the fix/dexalot_case_sensitivity branch March 31, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants