-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Adds case-sensitive trading pairs handling for Dexalot #80
(fix) Adds case-sensitive trading pairs handling for Dexalot #80
Conversation
hi @petioptrv Tests performed:
Currently
1.)
2.) 3.) 4.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests performed:
- Clone and install PR 6191+ gatewayPR80
- start the bot and gatewayPR80
- add balance for BTC.b and WETH.e
- added gateway connector-tokens dexalot_avalanche_dexalot BTC.B,WETH.E
- checked that bot shows correct balance for WETH.E and for BTC.B
- created pureMM/amm_arb startegy using BTC.B-USDC and WETH.E-USDC
- review that bot placed the orders for BTC.B-USDC, WETH.E-USDC and AVAX-USDC Pair
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests performed:
- Clone and install PR 6191+ gatewayPR80
- start the bot and gatewayPR80
- add balance for BTC.b and WETH.e
- added gateway connector-tokens dexalot_avalanche_dexalot BTC.B,WETH.E
- checked that bot shows correct balance for WETH.E and for BTC.B
- created pureMM/amm_arb startegy using BTC.B-USDC and WETH.E-USDC
- review that bot placed the orders for BTC.B-USDC, WETH.E-USDC and AVAX-USDC Pair
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This PR adds handling of case-sensitive trading pairs to the Dexalot connector.
Tests performed by the developer:
Tips for QA testing:
Please ensure that case sensitive trading pairs don't cause problems for the bot.