Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/openocean updates #75

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

onjeffery
Copy link

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
openocean add bsc,cronos,arbitrum and optimism chains

Tests performed by the developer:

Tips for QA testing:

@rapcmia
Copy link
Contributor

rapcmia commented Mar 27, 2023

Hi @onjeffery thanks for submitting this PR, please also add a thread on our proposal-discussions and info about it on discord so the community is aware and cast votes for the snapshot. Thank you

image

@onjeffery
Copy link
Author

Hi @onjeffery thanks for submitting this PR, please also add a thread on our proposal-discussions and info about it on discord so the community is aware and cast votes for the snapshot. Thank you

image

ok created

@onjeffery onjeffery force-pushed the feat/openocean-updates branch from 62531f6 to 03c41c0 Compare March 29, 2023 01:49
@rapcmia rapcmia requested review from fengtality, rapcmia and nikspz April 4, 2023 02:25
Copy link
Contributor

@fengtality fengtality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please submit changes to OpenOcean page in docs: https://github.com/hummingbot/hummingbot-site/blob/main/docs/exchanges/openocean.md

@nikspz
Copy link
Contributor

nikspz commented Apr 4, 2023

Failed to do initial token approval using openocean_binance-smart-chain_mainnet

Steps:
Approve tokens on the exchange/bot side
Create/start amm_arb strategy using openocean_binance-smart-chain_mainnet

Actual:
Failed to start strategy, bot stuck into openocean_binance-smart-chain_mainnet not ready: waiting for allowances: use trading interface to do manual approval..

Expected:
Bot use token that approved manually on metamask and calculate profitability

image
image

Same wallet using sushiswap_binance-smart-chain_mainnet

image
image

Same thing for openocean_ethereum_arbitrum_one and openocean optimism, not ready: waiting for allowances: use trading interface to do manual approval..

However works for uniswap_ethereum_arbitrum_one

image

@rapcmia
Copy link
Contributor

rapcmia commented Apr 5, 2023

PR update:

  • Run endpoint tests using thunder client
  • Port, wallet {add, remove}, balances and poll all ok ✅

However for arbitrum and optimism we are not able to proceed with allowance and approve endpoints and getting the same behavior reported above. While the previous commend shows issue on binance-smart-chain, we are able to run the endpoints without any issues at the moment

Arbitrum one
image

Optimism
image

Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Ethereum optimism and arbitrum, BSC and Cronos added for openocean
Checked balance successfully for openocean on the added connector chains

Note: there's ongoing issue with allowances/approval mentioned above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants