-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/openocean updates #75
Feat/openocean updates #75
Conversation
Hi @onjeffery thanks for submitting this PR, please also add a thread on our |
ok created |
62531f6
to
03c41c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please submit changes to OpenOcean page in docs: https://github.com/hummingbot/hummingbot-site/blob/main/docs/exchanges/openocean.md
Failed to do initial token approval using openocean_binance-smart-chain_mainnet Steps: Actual: Expected: Same wallet using sushiswap_binance-smart-chain_mainnet Same thing for However works for |
PR update:
However for arbitrum and optimism we are not able to proceed with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Ethereum optimism and arbitrum, BSC and Cronos added for openocean
Checked balance successfully for openocean on the added connector chains
Note: there's ongoing issue with allowances/approval mentioned above
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
openocean add bsc,cronos,arbitrum and optimism chains
Tests performed by the developer:
Tips for QA testing: