-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add sushiswap networks #60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at/add-sushiswap-networks
…/add-sushiswap-networks
Test performed:
|
nikspz
previously approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tests performed:
- Cloned and installed gwPR60
- Connected sushiswap_avalanche_avalanche
- balance: ok
- created amm_arb using sushiswap_avalanche_avalanche: ok
- Approved WAVAX,USDT on the sushiswap
- Was able to start amm_arb strategy using sushiswap_avalanche_avalanche
- connected sushiswap_ethereum_arbitrum_one
- balance: ok
- created amm_arb using sushiswap_ethereum_arbitrum_one: ok
- Approved WETH,USDC on the sushiswap
- Was able to start amm_arb strategy using sushiswap_ethereum_arbitrum_one
- connected sushiswap_harmony_mainnet
- balance: ok
- created amm_arb using sushiswap_harmony_mainnet: ok
- Approved WONE,USDC on the sushiswap
- Was able to start amm_arb strategy using sushiswap_harmony_mainnet
2 tasks
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request: