Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add sushiswap networks #60

Merged
merged 8 commits into from
Mar 15, 2023
Merged

Conversation

fengtality
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Adds support for Sushiswap on the Avalanche, Arbitrum and Harmony chains

@fengtality fengtality requested a review from rapcmia March 15, 2023 03:43
@nikspz
Copy link
Contributor

nikspz commented Mar 15, 2023

Test performed:

  • Cloned and installed gwPR60
  • Checked gateway list added avalanche, harmony and ethereum(arbitrum) to sushiswap
  • Connected sushiswap_avalanche_avalanche
  • connected sushiswap_ethereum_arbitrum_one
    • balance: ok
    • created amm_arb using sushiswap_ethereum_arbitrum_one: ok
    • WETH,USDC could be approved using approve-tokens command.
    • Approved BentoBox, WETH,USDC manually on the sushiswap
    • Started amm_arb strategy using arbitrum
  • connected sushiswap_harmony_mainnet
    • balance: ok
    • created amm_arb using sushiswap_harmony_mainnet: ok
    • WONE, USDC not approved using approve-tokens command. (Error on POST evm/approve)
    • Approved WONE,USDC manually on the sushiswap
    • Was able to start amm_arb strategy using harmony

nikspz
nikspz previously approved these changes Mar 15, 2023
Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tests performed:

  • Cloned and installed gwPR60
  • Connected sushiswap_avalanche_avalanche
    • balance: ok
    • created amm_arb using sushiswap_avalanche_avalanche: ok
    • Approved WAVAX,USDT on the sushiswap
    • Was able to start amm_arb strategy using sushiswap_avalanche_avalanche
  • connected sushiswap_ethereum_arbitrum_one
    • balance: ok
    • created amm_arb using sushiswap_ethereum_arbitrum_one: ok
    • Approved WETH,USDC on the sushiswap
    • Was able to start amm_arb strategy using sushiswap_ethereum_arbitrum_one
  • connected sushiswap_harmony_mainnet
    • balance: ok
    • created amm_arb using sushiswap_harmony_mainnet: ok
    • Approved WONE,USDC on the sushiswap
    • Was able to start amm_arb strategy using sushiswap_harmony_mainnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants