-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch order creation and cancelation for CLOB and injective #55
Merged
rapcmia
merged 10 commits into
hummingbot:development
from
CoinAlpha:feat/injective_w_batch_update
Mar 13, 2023
Merged
Batch order creation and cancelation for CLOB and injective #55
rapcmia
merged 10 commits into
hummingbot:development
from
CoinAlpha:feat/injective_w_batch_update
Mar 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@vic-en Please review the code here and add a description. |
…a/gateway into feat/injective_w_batch_update
fengtality
approved these changes
Mar 8, 2023
2 tasks
nikspz
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test performed:
- Clone and installed feature branch
- Started gateway successfully
- Created/started pureMM using injective: was able to create and cancel orders
- Curl commands:
- balances: ok
- injective_batch_create: ok, created orders with the correct side and price
- clob/orders: ok, checked order_id
- injective_batch_delete: ok deleted orders with order-id provided
Merged the PR in behalf of foundation team to development branch and will be available on the next hummingbot version 1.14.0 |
2 tasks
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr builds on pr #51 . It adds the
/clob/batchOrders
endpoint to the club route.Due to that, the following should be tested: