Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch order creation and cancelation for CLOB and injective #55

Merged

Conversation

james-hummingbot
Copy link
Contributor

@james-hummingbot james-hummingbot commented Mar 8, 2023

This pr builds on pr #51 . It adds the /clob/batchOrders endpoint to the club route.
Due to that, the following should be tested:

## post batch orders create
curl -s -X POST -k --key $GATEWAY_KEY --cert $GATEWAY_CERT -H "Content-Type: application/json" -d "$(envsubst < ./requests/injective_batch_create.json)" https://localhost:15888/clob/batchOrders | jq

## post batch orders delete
curl -s -X POST -k --key $GATEWAY_KEY --cert $GATEWAY_CERT -H "Content-Type: application/json" -d "$(envsubst < ./requests/injective_batch_delete.json)" https://localhost:15888/clob/batchOrders | jq

@james-hummingbot
Copy link
Contributor Author

@vic-en Please review the code here and add a description.

Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performed:

  • Clone and installed feature branch
  • Started gateway successfully
  • Created/started pureMM using injective: was able to create and cancel orders
  • Curl commands:
    • balances: ok
    • injective_batch_create: ok, created orders with the correct side and price
    • clob/orders: ok, checked order_id
    • injective_batch_delete: ok deleted orders with order-id provided

@rapcmia rapcmia merged commit 5df9c20 into hummingbot:development Mar 13, 2023
@rapcmia
Copy link
Contributor

rapcmia commented Mar 13, 2023

Merged the PR in behalf of foundation team to development branch and will be available on the next hummingbot version 1.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants