Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) change fs-extra remove fn name #35

Merged
merged 4 commits into from
Feb 21, 2023

Conversation

fengtality
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Fix wallet remove function, solves failing test

await fse.rm(`./conf/wallets/${req.chain}/${req.address}.json`, {
force: true,
});
await fse.remove(`./conf/wallets/${req.chain}/${req.address}.json`);

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This path depends on a [user-provided value](1).
@fengtality fengtality merged commit fef921a into development Feb 21, 2023
@fengtality fengtality deleted the fix/fix-remove-wallet-test branch February 21, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant