Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ add base network #339

Closed

Conversation

LautaroNavarro
Copy link

@LautaroNavarro LautaroNavarro commented Jul 23, 2024

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Add base network, and mainnet + sepolia chains

Tests performed by the developer:

  • Tested creating a connection using uniswap connect + network base + chain mainnet
  • Tested creating a connection using uniswap connect + network base + chain sepolia
  • Tested getting the balance for mainnet wallet
  • Tested getting the balance for sepolia wallet
    Screenshot 2024-07-23 at 16 21 49
    Screenshot 2024-07-23 at 16 15 22

Tips for QA testing:
To test this with the hummingbot client you will need to add the base network to the native_tokens list in the gateway_config_utils.py file. (Inside of the hummingbot repository, and not the gateway repository)

@LautaroNavarro LautaroNavarro changed the title Add base network feat/ add base network Jul 23, 2024
@LautaroNavarro
Copy link
Author

@fengtality can you approve the workflow run?

@fengtality
Copy link
Contributor

@LautaroNavarro I don't think Base should be a separate chain, but rather a Ethereum L2 network, like Arbitrum and Optimism. There's actually a separate Gateway PR for Base support: #329

I'll take a look at your changes and see what I can add

@fengtality
Copy link
Contributor

Closing in favor of #329.

Rationale:

  • Base should be added as an Ethereum network, not a new chain
  • Base token lists included in this PR are wrong

@fengtality fengtality closed this Jul 25, 2024
@LautaroNavarro
Copy link
Author

@fengtality thanks! Yes, adding base as an Ethereum network make sense since it's a L2. About the tokens, I'm not really sure where do you get the list from, I went to uniswap and took them from the requests.
Do you have an ETA for #329 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants