(feat) Sepolia testnet support on Uniswap connector #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes look good, but I think the dev should also change the tests from Goerli to Sepolia as part of this fix. |
|
This PR needs more work. To complete this bounty, the dev should ensure that the Uniswap tests (which currently use Goerli) are modified to work on Sepolia using Sepolia test tokens. Currently, they are failing. However, this may be difficult since there doesn't seem to be any tokens that trade on Uniswap Sepolia. It might make more sense to convert the unit tests to use Base. |
|
I added Sepolia support in #329, but the tests haven't yet been updated to use it, so the bounty is still available for any dev who wants to update the Ethereum and Uniswap tests for Sepolia |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
- [x] Your code builds clean without any errors or warnings
- [x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")
A description of the changes proposed in the pull request:
Added support for the Ethereum Sepolia testnet on Uniswap connector. Also included an initial token list.