Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Add retry and set submittx to submit and wait #282

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

mlguys
Copy link
Contributor

@mlguys mlguys commented Feb 18, 2024

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Add retry for getting transaction data since rcp node could slow to sync up with latest transactions
  • Set submitting transaction to submitAndWait to make sure transaction got posted on the ledger

Tests performed by the developer:

  • Run PMM strategy on SOLO/XRP
  • Run sample scripts:
    • scripts/archived_scripts/examples_xrpl_scripts/xrpl_format_status.py
    • scripts/archived_scripts/examples_xrpl_scripts/xrpl_simple_arbitrage.py
    • scripts/archived_scripts/examples_xrpl_scripts/xrpl_simple_pmm.py
    • scripts/archived_scripts/examples_xrpl_scripts/xrpl_simple_rsi.py
    • scripts/archived_scripts/examples_xrpl_scripts/xrpl_simple_xemm.py

Tips for QA testing:

@fengtality fengtality merged commit b8d9764 into development Feb 19, 2024
1 of 2 checks passed
@fengtality fengtality deleted the fix/xrpl-add-retry-and-wait-for-submit branch February 19, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants