Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix / dexalot #266

Merged
merged 2 commits into from
Jan 17, 2024
Merged

fix / dexalot #266

merged 2 commits into from
Jan 17, 2024

Conversation

vic-en
Copy link
Collaborator

@vic-en vic-en commented Jan 16, 2024 •
edited
Loading

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Tests performed by the developer:

Tips for QA testing:

@vic-en vic-en self-assigned this Jan 16, 2024
@vic-en
Copy link
Collaborator Author

vic-en commented Jan 16, 2024

Fixes #232

rapcmia
rapcmia approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Setup this PR with latest development gateway on source
  • Connect dexalot wallet ok
  • Run gateway balance and compare data from connector and exchange
    image
    • Setup simple pure market making on dexalot for EUROC and SAVAX
      • User must use SAVAX instead of sAVAX

@rapcmia rapcmia merged commit b81b9c7 into hummingbot:development Jan 17, 2024
3 checks passed
@rapcmia
Copy link
Contributor

rapcmia commented Jan 17, 2024

Merged to development and part of release version 1.24.0

@rapcmia rapcmia mentioned this pull request Jan 22, 2024
Merged
2 tasks
@nikspz nikspz mentioned this pull request Jan 29, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rapcmia rapcmia rapcmia approved these changes

Assignees

@vic-en vic-en

Labels
None yet
Projects
Pull Request Status
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vic-en @rapcmia