-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/ QuipuSwap connector for Tezos chain #252
Conversation
121d010
to
cf53680
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test performed:
- Cloned and installed latest development + gwPR252
- Created wallet at kukai.app, not able to use passphrase, not going. no private key available
- Created wallet https://templewallet.com/ and used this private key
- connected quipuswap_tezos_mainnet with templewallet key successfully
- checked balance successfully
- created amm_arb strategy using QuipuSwap_tezos_mainnet succesfully
Note: order execution not tested since testnet not available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See review comments. Also please resolve conflicts since there was a Pancakeswap PR which was recently merged in.
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
This reverts commit b0b432e.
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Hi @OjusWiZard |
Hi @david-hummingbot |
Perfect, thanks @OjusWiZard, we'll include this in the release for 1.24. We'll be announcing the release shortly. |
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Added support for QuipuSwap Dex on the Tezos chain.
Tests performed by the developer:
amm_arb
between Binance and QuipuSwap.Tips for QA testing: