-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/pancakeswap v3 price calculation. #251
feat/pancakeswap v3 price calculation. #251
Conversation
Sync gateway / staging to main gateway 1.22.0
@vic-en can you take a look at this PR since you worked on PancakeSwap upgrade? |
@fengtality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xcodercrane
Just one comment for you, you can remove the router abi file as I see it's no longer used.
@fengtality
As mentioned earlier, this changes pertain to the swap funtionalities.
As it is, it integrates the latest smart router which allow swaps to automatically use v3 pools when available.
That being said, there's no funtionality to strictly use v3 pool only as available in uniswap code. So I guess further decision is up to you.
fix/ add XRPL testnet fix to staging
Sync Gateway / Gateway staging -> master for Hummingbot version 1.23.0
@vic-en |
@vic-en @0xcodercrane @fengtality what about this pr, what else is missing to merge it? |
Could you please approve ci/cd run @fengtality ? |
adding last fixes of unit test. |
approved workflow run @0xcodercrane |
thank you. how can I see which tests are failing from ci/cd. Would you help me on that? @cardosofede |
hey admins! anyone please approve the workflow run? |
@0xcodercrane Thanks - looks like tests are passing now. I'll review and address @vic-en's comment above shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks for the addition of the subgraph connection - I can definitely see why this improves latency for price fetching.
@jellebuth Thanks for testing this PR. Does the change from Ankr to LlamaRPC as default provider fix your issues?
@0xcodercrane Requested changes:
Review the fields in pancakeswap.yml
in the templates folder. If any are not used anymore after this change, please remove them from this file. This will let users know what options they have to modify how the connector works.
@vic-en I don't think we need to add an option for users to select only V2 or V3 pools, unless they request it afterwards.
Actually, I will approve merge this PR in now, so that other outstanding PRs can update their dependencies. @0xcodercrane please clean up the Pancakeswap default configs template at your convenience. |
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
Tips for QA testing: