Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fix yarn #246

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Fix/fix yarn #246

merged 3 commits into from
Dec 1, 2023

Conversation

fengtality
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Fixes yarn dependencies
  • Updates axios

@fengtality
Copy link
Contributor Author

@rapcmia I will merge this in to fix these dependencies before the PancakeSwapV3 and Osmosis connectors are reviewed.

@fengtality fengtality merged commit 4afa163 into development Dec 1, 2023
4 checks passed
@fengtality fengtality deleted the fix/fix-yarn branch December 1, 2023 22:09
@chasevoorhees
Copy link
Contributor

chasevoorhees commented Dec 7, 2023

@rapcmia I will merge this in to fix these dependencies before the PancakeSwapV3 and Osmosis connectors are reviewed.

I'd merged this into my Osmosis feature branch a few days ago and just now noticed my tests started failing.

I ended up doing a clean pull of https://github.com/hummingbot/gateway/tree/development

And here's yarn test from that - every module that uses axios is failing now
image

@chasevoorhees
Copy link
Contributor

I got jest working again

jest.config.js

  moduleNameMapper: {
    eccrypto: '<rootDir>/test/mock/eccrypto-mock.js',
    axios: '<rootDir>/node_modules/axios/dist/node/axios.cjs'
  },

pecuniafinance@6b6a0ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants