Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vic en feat/pancake swap v3 #244

Closed
wants to merge 7 commits into from

Conversation

fengtality
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Resolved merge conflicts with development

@fengtality fengtality requested a review from rapcmia December 1, 2023 21:14
@fengtality fengtality mentioned this pull request Dec 1, 2023
2 tasks
@fengtality
Copy link
Contributor Author

fengtality commented Dec 2, 2023

I encountered the following error when fetching allowances for an address on pancakeswapLP connector:

{
    "message": "The spender param is not a valid Ethereum address (0x followed by 40 hexidecimal characters).",
    "httpErrorCode": 404,
    "errorCode": -1,
    "stack": "Error: The spender param is not a valid Ethereum address (0x followed by 40 hexidecimal characters).\n    at throwIfErrorsExist (/Users/feng/Code/gateway/dist/src/services/validators.js:38:15)\n    at /Users/feng/Code/gateway/dist/src/services/validators.js:103:40\n    at EVMController.<anonymous> (/Users/feng/Code/gateway/dist/src/chains/ethereum/evm.controllers.js:155:65)\n    at Generator.next (<anonymous>)\n    at /Users/feng/Code/gateway/dist/src/chains/ethereum/evm.controllers.js:8:71\n    at new Promise (<anonymous>)\n    at __awaiter (/Users/feng/Code/gateway/dist/src/chains/ethereum/evm.controllers.js:4:12)\n    at EVMController.allowances (/Users/feng/Code/gateway/dist/src/chains/ethereum/evm.controllers.js:154:16)\n    at /Users/feng/Code/gateway/dist/src/chains/chain.controller.js:49:51\n    at Generator.next (<anonymous>)"
}

Same issue occurs when running /chain/approve with pancakeswapLP as spender.

Since Hummingbot checks allowances, I get this error on startup

Screen Shot 2023-12-01 at 4 25 08 PM

@vic-en
Copy link
Collaborator

vic-en commented Dec 3, 2023

@fengtality I updated the branch and reopened a pr with complete solution - #247

@fengtality fengtality closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants