Feat/curve connector #190

vic-en · 2023-08-23T12:26:31Z

Before submitting this PR, please make sure:

Your code builds clean without any errors or warnings
You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Adds Curve connector as requested in #101

Tests performed by the developer:

End-to-end testing
Curl test

Tips for QA testing:

End-to-end testing
Curl test

…nto feat/curve_connector

nikspz · 2023-09-07T04:41:28Z

hi @vic-en Could you please resolve PR conflicts?

…nto feat/curve_connector

nikspz · 2023-10-02T13:28:49Z

hi @vic-en Could you please resolve branch conflicts?

vic-en · 2023-10-03T04:05:45Z

@nikspz Thanks for the remider. I'll do that soon.

…nto feat/curve_connector

into feat/curve_connector

nikspz · 2023-10-04T06:45:46Z

@vic-en

Failed to connect curve_ethereum_arbitrum_one, we changed arbitrum_one to arbitrum in this PR:
#182

https://github.com/hummingbot/gateway/pull/190/files#diff-3da0f62b628e70f6c6c61c5639b159cef26ac44014ad209777d499620c694fe4R14

nikspz · 2023-10-06T12:45:26Z

@vic-en Failed to connect, we changed arbitrum_one to arbitrum in this PR: #182

https://github.com/hummingbot/gateway/pull/190/files#diff-3da0f62b628e70f6c6c61c5639b159cef26ac44014ad209777d499620c694fe4R14

Also connected ethereum mainnet, avalanche and polygon successfully, however failed connecting curve_ethereum_optimism:

logs_hummingbot.log
logs_gateway_app.log

vic-en · 2023-10-16T17:10:55Z

@nikspz This is ready for review again.

Note that you may have to restart the stategy a second time if apporval don't go through the first time.

nikspz · 2023-10-16T20:25:45Z

@vic-en Could you please add fix for arbitrum_one to arbitrum here?

Failed to connect curve_ethereum_arbitrum,
For the reference: we changed arbitrum_one to arbitrum in this PR #182

https://github.com/hummingbot/gateway/pull/190/files#diff-3da0f62b628e70f6c6c61c5639b159cef26ac44014ad209777d499620c694fe4R14

vic-en · 2023-10-16T20:42:55Z

@nikspz Renamed.

nikspz · 2023-10-17T16:28:38Z

Test performed:
- Cloned and installed latest dev branch + gwPR190
- connected curve_ethereum_mainnet and curve_avalanche_avalanche successfully
- checked balance for curve_ethereum_mainnet and curve_avalanche_avalanche successfully
- connected curve_ethereum_arbitrum, curve_ethereum_optimism successfully
- gateway connector-tokens curve_ethereum_arbitrum WETH,USDC added successfully
- checked balance curve_ethereum_arbitrum, curve_ethereum_optimism successfully
- token approval for curve_ethereum_arbitrum successful
  - https://arbiscan.io/tx/0x1967378a3b61bbda635e8b283ba56d95a3b3c98aada01ddd8f42b5a8f1ed7099
- created/started amm_arb strategy using curve_ethereum_arbitrum
- failed to check buy/sell/mid prices for curve_ethereum_arbitrum

Steps to reproduce:

Cloned and installed latest dev branch + gwPR190
gateway connect curve_ethereum_mainnet, gateway connect curve_ethereum_arbitrum
create/start amm_arb using this connectors, review no price showed for curve

Same thing for Curl tests for arbitrum and mainnet:

{
  "connector": "curve",
  "chain": "ethereum",
  "network": "mainnet",
  "quote": "WETH",
  "base": "USDC",
  "amount": "0.04",
  "side": "BUY"
}

vic-en · 2023-10-18T03:46:50Z

@nikspz
I'm using the registry to find the best pool. That implies that the registry couldn't find a pool that has reserves for the tokens in that pair.

For Arbitrum(https://curve.fi/#/arbitrum/pools), there are only 18 pools in total.

For Eth mainnet(https://curve.fi/#/ethereum/pools), no single pool has reserves for both WETH and USDC.

Note that some pools have ETH reserves. Unfortunately, we don't currently support that case. So there may be a pool that has ETH and USDC reserves.

vic-en · 2023-10-18T03:48:07Z

I'll push a commit to properly return an error rather than Zero prices.

pls let me know who will be doing dev review.

Thanks.

nikspz · 2023-10-18T20:32:09Z

Test performed:
- Cloned and installed latest development and gwPR190 latest commit 382b551
- created/start amm_arb using curve_ethereum_arbitrum
- curl on curve:
  - ethereum_mainnet: Error: Price query failed: No pool found for
  - ethereum_arbitrum: Error: Price query failed: No pool found for
  - polygon_mainnet: Error: Price query failed: No pool found for
  - avalanche_avalanche Error: unsupported chain or connector

amm_arb using curve_ethereum_arbitrum

vic-en · 2023-10-18T20:34:51Z

@nikspz You can also test with markets that have a pool.

nikspz · 2023-10-19T16:34:58Z

Test performed:
- Cloned and installed latest development and gwPR190 latest commit [382b551](382b551)
- test another pairs that have pools on curve
- ethereum mainnet
- triple pool WBTC, ETH, USDC (factory, (Factory pool is permissionless, deployed by anyone))

ethereum mainnet: WBTC-USDC ❌Price query failed: No pool found

pool with one pair FRAX-USDC ✅
pool with 3 tokens WBTC-ETH-USDT works ✅
- WBTC-USDT and WETH-USDT ✅

avalanche
- Pool DAI.e-USDC.e - request failed with Error: unsupported chain or connector ❌❌

            {
              "connector": "curve",
              "chain": "avalanche",
              "network": "avalanche",
              "quote": "USDC.e",
              "base": "DAI.e",
              "amount": "100",
              "side": "BUY"
            }

polygon mainnet
- pool https://curve.fi/#/polygon/pools/atricrypto3/deposit
- have WBTC-USDC
- request failed ❌ with error: Price query failed: No pool found for 0x2791Bca1f2de4661ED88A30C99A7a9449Aa84174 to 0x1BFD67037B42Cf73acF2047067bd4F2C47D9BfD6 (however pool above has liquidity for it)

WBTC-USDT
- request failed ❌with error: Price query failed: No pool found for
USDT-USDC
- request failed ❌❌ with error:

            {
              "message": "Price query failed: missing revert data in call exception; Transaction reverted without a reason string [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (data=\"0x\", transaction={\"gasLimit\":{\"type\":\"BigNumber\",\"hex\":\"0x11d16339\"},\"to\":\"0x2a426b3Bb4fa87488387545f15D01d81352732F9\",\"data\":\"0x4e21df75000000000000000000000000c2132d05d31c914a87c6611c10748aeb04b58e8f0000000000000000000000002791bca1f2de4661ed88a30c99a7a9449aa841740000000000000000000000000000000000000000000000000000000005f5e100\",\"accessList\":null}, error={\"reason\":\"processing response error\",\"code\":\"SERVER_ERROR\",\"body\":\"{\\\"jsonrpc\\\":\\\"2.0\\\",\\\"id\\\":47,\\\"error\\\":{\\\"code\\\":-32000,\\\"message\\\":\\\"execution reverted\\\"}}\",\"error\":{\"code\":-32000},\"requestBody\":\"{\\\"method\\\":\\\"eth_call\\\",\\\"params\\\":[{\\\"gas\\\":\\\"0x11d16339\\\",\\\"to\\\":\\\"0x2a426b3bb4fa87488387545f15d01d81352732f9\\\",\\\"data\\\":\\\"0x4e21df75000000000000000000000000c2132d05d31c914a87c6611c10748aeb04b58e8f0000000000000000000000002791bca1f2de4661ed88a30c99a7a9449aa841740000000000000000000000000000000000000000000000000000000005f5e100\\\"},\\\"latest\\\"],\\\"id\\\":47,\\\"jsonrpc\\\":\\\"2.0\\\"}\",\"requestMethod\":\"POST\",\"url\":\"https://polygon-mainnet.infura.io/v3/4937790794744fe781f3f9b0e64c1d83\"}, code=CALL_EXCEPTION, version=providers/5.7.2)",
              "httpErrorCode": 500,
              "errorCode": 1013,
              "stack": "Error: Price query failed: missing revert data in call exception; Transaction reverted without a reason string [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (data=\"0x\", transaction={\"gasLimit\":{\"type\":\"BigNumber\",\"hex\":\"0x11d16339\"},\"to\":\"0x2a426b3Bb4fa87488387545f15D01d81352732F9\",\"data\":\"0x4e21df75000000000000000000000000c2132d05d31c914a87c6611c10748aeb04b58e8f0000000000000000000000002791bca1f2de4661ed88a30c99a7a9449aa841740000000000000000000000000000000000000000000000000000000005f5e100\",\"accessList\":null}, error={\"reason\":\"processing response error\",\"code\":\"SERVER_ERROR\",\"body\":\"{\\\"jsonrpc\\\":\\\"2.0\\\",\\\"id\\\":47,\\\"error\\\":{\\\"code\\\":-32000,\\\"message\\\":\\\"execution reverted\\\"}}\",\"error\":{\"code\":-32000},\"requestBody\":\"{\\\"method\\\":\\\"eth_call\\\",\\\"params\\\":[{\\\"gas\\\":\\\"0x11d16339\\\",\\\"to\\\":\\\"0x2a426b3bb4fa87488387545f15d01d81352732f9\\\",\\\"data\\\":\\\"0x4e21df75000000000000000000000000c2132d05d31c914a87c6611c10748aeb04b58e8f0000000000000000000000002791bca1f2de4661ed88a30c99a7a9449aa841740000000000000000000000000000000000000000000000000000000005f5e100\\\"},\\\"latest\\\"],\\\"id\\\":47,\\\"jsonrpc\\\":\\\"2.0\\\"}\",\"requestMethod\":\"POST\",\"url\":\"https://polygon-mainnet.infura.io/v3/4937790794744fe781f3f9b0e64c1d83\"}, code=CALL_EXCEPTION, version=providers/5.7.2)\n    at /home/etozhe/gwcu2/dist/src/connectors/uniswap/uniswap.controllers.js:74:23\n    at Generator.throw (<anonymous>)\n    at rejected (/home/etozhe/gwcu2/dist/src/connectors/uniswap/uniswap.controllers.js:6:65)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
            }

ethereum arbitrum
- pool MIM USDC USDT (Factory) https://curve.fi/#/arbitrum/pools/factory-v2-0/deposit
- MIM-USDT
- amm/price successful request ✅
arbitrum MIM-USDC ❌failed to get price:

fengtality

LGTM

fengtality · 2023-10-21T17:45:31Z

I added a commit that fixes yarn.lock: #215

vic-en and others added 9 commits August 15, 2023 13:57

initial commit

2d60994

curve update

0c01d15

Merge branch 'development' of https://github.com/hummingbot/gateway i…

6206384

…nto feat/curve_connector

update

7c28b04

Merge branch 'development' of https://github.com/hummingbot/gateway i…

417d3b3

…nto feat/curve_connector

fix linter issue

fa30d4d

Merge branch 'development' into feat/curve_connector

2e167f3

Merge branch 'development' into feat/curve_connector

656cb54

Merge branch 'development' into feat/curve_connector

fba9b48

Merge branch 'development' of https://github.com/hummingbot/gateway i…

a2ef031

…nto feat/curve_connector

vic-en added 5 commits October 3, 2023 08:41

update package

2992c48

Merge branch 'development' of https://github.com/hummingbot/gateway i…

e04dc4d

…nto feat/curve_connector

Merge branch 'development' of https://github.com/hummingbot/gateway i…

76057eb

…nto feat/curve_connector

Merge branch 'feat/curve_connector' of https://github.com/vic-en/gateway

bbf0ff4

into feat/curve_connector

update curve import

64e09d2

vic-en and others added 3 commits October 16, 2023 11:58

update curve

ad894a3

cleanup

396ba80

Merge branch 'development' into feat/curve_connector

60e95a7

rename arbitrum_one to arbitrum

41ef17b

Throw error when no best pool found

382b551

rapcmia requested review from fengtality and nikspz October 20, 2023 02:05

fengtality approved these changes Oct 21, 2023

View reviewed changes

fengtality mentioned this pull request Oct 21, 2023

feat/curve connector with resolved yarn.lock #215

Merged

fengtality merged commit 886b768 into hummingbot:development Nov 7, 2023
2 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/curve connector #190

Feat/curve connector #190

vic-en commented Aug 23, 2023 •

edited

Loading

nikspz commented Sep 7, 2023

nikspz commented Oct 2, 2023

vic-en commented Oct 3, 2023

nikspz commented Oct 4, 2023 •

edited

Loading

nikspz commented Oct 6, 2023

vic-en commented Oct 16, 2023

nikspz commented Oct 16, 2023

vic-en commented Oct 16, 2023

nikspz commented Oct 17, 2023

vic-en commented Oct 18, 2023

vic-en commented Oct 18, 2023

nikspz commented Oct 18, 2023

vic-en commented Oct 18, 2023

nikspz commented Oct 19, 2023 •

edited

Loading

fengtality left a comment

fengtality commented Oct 21, 2023

Feat/curve connector #190

Feat/curve connector #190

Conversation

vic-en commented Aug 23, 2023 • edited Loading

nikspz commented Sep 7, 2023

nikspz commented Oct 2, 2023

vic-en commented Oct 3, 2023

nikspz commented Oct 4, 2023 • edited Loading

nikspz commented Oct 6, 2023

vic-en commented Oct 16, 2023

nikspz commented Oct 16, 2023

vic-en commented Oct 16, 2023

nikspz commented Oct 17, 2023

vic-en commented Oct 18, 2023

vic-en commented Oct 18, 2023

nikspz commented Oct 18, 2023

vic-en commented Oct 18, 2023

nikspz commented Oct 19, 2023 • edited Loading

fengtality left a comment

Choose a reason for hiding this comment

fengtality commented Oct 21, 2023

vic-en commented Aug 23, 2023 •

edited

Loading

nikspz commented Oct 4, 2023 •

edited

Loading

nikspz commented Oct 19, 2023 •

edited

Loading