Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/gateway tests #188

Merged
merged 10 commits into from
Aug 22, 2023
Merged

Fix/gateway tests #188

merged 10 commits into from
Aug 22, 2023

Conversation

fengtality
Copy link
Contributor

@fengtality fengtality commented Aug 21, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Move bronze connectors tests to /test-bronze folder
  • Fix tests in /test folder
  • Move clob connector tests to /test-bronze folder. This needed because the CLOB tests which are based on the Injective connector currently call Injective network endpoints. While tests pass when you run Jest on the /clob folder alone, the network calls cause conflicts with other test suites when run together.
2023-08-22 09:28:16 | info | 	Injective endpoints: {"indexer":"https://k8s.global.mainnet.exchange.grpc-web.injective.network","grpc":"https://k8s.global.mainnet.chain.grpc-web.injective.network","rpc":"https://k8s.global.mainnet.tm.injective.network","rest":"https://k8s.global.mainnet.lcd.injective.network","chronos":"https://k8s.global.mainnet.chronos.grpc-web.injective.network","explorer":"https://k8s.global.mainnet.explorer.grpc-web.injective.network"}
  • Ideally, the clob tests should be refactored to use a different connector OR patched so that the Injective network calls don't occur.

@fengtality fengtality marked this pull request as ready for review August 21, 2023 20:09
@fengtality fengtality requested a review from cardosofede August 21, 2023 20:26
Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rapcmia rapcmia merged commit 285a9d5 into development Aug 22, 2023
@rapcmia rapcmia deleted the fix/gateway-tests branch August 22, 2023 05:31
@rapcmia
Copy link
Contributor

rapcmia commented Aug 22, 2023

Merged to development and part of 1.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants