Fix/ unhandled error when using USDC.e

[isreallee82]

Before submitting this PR, please make sure:

• Your code builds clean without any errors or warnings
• You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

• "fix"

** after the latest merge for commit **

• you should remove USDC.E if added✅

❌ Setup connector-token command and add USDC.e or USDC.E ❌

then

• Setup connector-token command and add USDC.e ✅
• Setup amm-arb with avalanche or uniswap arbitrum_one connector ✅
• Observe the display balance upon starting the amm-arb ✅

"refactor" changes made

"symbol":"USDC.E",
"symbol":"USDC.e",

Tests performed by the developer:

• Setup connector-token command and add USDC.e or USDC.E ❌ threw duplicate

• Setup amm-arb with avalanche or uniswap arbitrum_one connector ✅
• Observe the display balance upon starting the amm-arb ✅

Tips for QA testing:

• Setup connector-token command and add USDC.e ✅
• Setup amm-arb with avalanche or uniswap arbitrum_one connector ✅
• Observe the display balance upon starting the amm-arb ✅

[isreallee82]

Uniswap unhandled error and duplicate values for USDC.e on ui

[nikspz]

I don't think changing arbitrum token list to USDC.e actually will fix the issue, since arbitrum was unable to trade using USDC.e before (this PR #133), but was okay with USDC.E. I will re-check this fix later

[isreallee82]

I don't think changing arbitrum token list to USDC.e actually will fix the issue, since arbitrum was unable to trade using USDC.e before (this PR #133), but was okay with USDC.E. I will re-check this fix later

alright please do but I am sure setting the symbol as USDC.E will conflit it and I noticed it was USDCE before it was refactored to USDC.E which was supposed to be USDC.e

[nikspz]

I guess previous changes in #133 was related we used rate oracle for calculation, current version had PR updates for not to use it hummingbot/hummingbot#6472 (rate_oracle_enabled is False by default)

Test performed using rate_oracle_enabled False, successful trades:

[nikspz]

@isreallee82

Is that nessasary change?

[nikspz]

Test performed:

• Cloned and install fix branch + latest development branch
• gateway connect uniswap_arbitrum_one
• Setup simple AMM arb and observed expected behavior, filled trades when setting market USDC.e for arbitrum_one and binance paper trade as 2nd connector ✅

• Setup simple AMM arb and observed the same error as Ralph mentioned in the Uniswap - Getting unhandled error when using USDC.e #143 when setting market USDC.E for arbitrum_one, and binance_paper_trade as 2nd connector ❌

[isreallee82]

Yes definitely it also resulting in the duplicates on the uiSent from my iPhoneOn 27 Jul 2023, at 9:47 AM, nikspz ***@***.***> wrote: @isreallee82 Is that nessasary change? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[isreallee82]

Ohh didn’t see that let me check Is that nessasary change? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[isreallee82]

Yes definitely it also resulting in the duplicates on the uiSent from my iPhoneOn 27 Jul 2023, at 9:47 AM, nikspz @.> wrote: @isreallee82 Is that nessasary change? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.>

That must be a typo, corrected that already. The email received wasn’t showing the pics.

[isreallee82]

I noticed the latest changes are trying to merge with the current pr I hope that doesn’t mean anything

[nikspz]

@isreallee82 Could you revert changes related to the changing arbitrum_one to arbitrum?
If you want to add this changes you:

1. Need to be assigned for Bug: Value error due to underscore in arbitrum_one #173
2. Create the SEPARATE PR for it (use different branch on your local repo)

[isreallee82]

@nikspz alright i willdo that

[isreallee82]

@nikspz please can you confirm if I did the right thing

[nikspz]

yes @isreallee82

[nikspz]

Checked previous commit on the PR, same changes
Test performed:

• Cloned and installed feature branch and latest development
• bot was able to trade using WETH-USDC.e
• the error/warning message that happened on USDC.E usage (development branch) not happened for me on this branch (changes to USDC.e)

NOTE: with these changes it will fail to trade with USDC.E then (getting exactly same issue reported in #143)
However default token in arbitrum has name USDC.e so I think it's correct to change
https://arbiscan.io/token/0xff970a61a04b1ca14834a43f5de4533ebddb5cc8

[nikspz]

@isreallee82 Could you please fix the conflicts?

[isreallee82]

alright @nikspz on that