Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/ Tezos and Plenty #156

Merged
merged 48 commits into from
Aug 20, 2023
Merged

Feat/ Tezos and Plenty #156

merged 48 commits into from
Aug 20, 2023

Conversation

OjusWiZard
Copy link
Contributor

@OjusWiZard OjusWiZard commented Jul 13, 2023 •
edited
Loading

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using an approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Adds Tezos Chain and Plenty connector into the gateway.

Tests performed by the developer:
Added various unit tests for all the functions.
Tested Plenty in Hummingbot (amm_arb between Binance and Plenty).

Tips for QA testing:
You will need to run the HummingBot app from the branch of PR #6475 on the HummingBot repo.
Then add a non-empty Tezos wallet using it.
Then create some strategy including Plenty Dex connector on it.
Then start the bot.

@OjusWiZard OjusWiZard mentioned this pull request Jul 13, 2023
Merged
2 tasks
@OjusWiZard OjusWiZard changed the title Feat/plenty Feat/ Tezos and Plenty Jul 13, 2023
@OjusWiZard OjusWiZard marked this pull request as ready for review July 13, 2023 17:57
OjusWiZard added 26 commits August 7, 2023 02:40
@OjusWiZard
(feat) add tezos chain support
1cc4a6e 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(feat) add sign from tezos wallet
3e9efa5 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) chainId type in Tezos TokenInfo
1da6dba 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix): add missing gasLimitTransaction in Tezosish
1966d7e 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) update manualGasPrice
52d5e73
@OjusWiZard
(fix) update tokens
304324f 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(feat) add /nextNonce route
120cf78 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) API bug fixes and improve compactibility
7105f66 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) update test for new compactibility
c1133b9 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(feat) add tezos chain support
5557cce 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix): add missing gasLimitTransaction in Tezosish
240a19c 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) update test for new compactibility
7f386a8 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) refactor tezos controller
11dba37 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) solve dependency conflict
f9a36db 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(feat) add getTokens in Tezos controller
819cf80 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) gasUsed significance according to eth
137c04a 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) add custom validateTezosTokenSymbols
8f43267 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) higher counter error in new taquito version
6cb1d3e 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) optimise getTokenAllowance
27fa133 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(refactor) token list path
31bfa18 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(feat) add missing test for new getTokens route
d9eaa0d 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(feat) add tezos chain support
dfaa111 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) solve dependency conflict
c18e6a2 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(feat) add plenty connector support
512caa4 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) CTEZ capitalization bug
3e18ae5 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(feat) add plenty tests
4b99e6a 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
OjusWiZard and others added 18 commits August 7, 2023 02:52
@OjusWiZard
(feat) add plenty routes and controllers tests
1cc356b 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) update Plenty router contract
e19cfd7 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(chore) add debug logs
4ba0677 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(feat) add plenty connector support
f5ef81a 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(cleanup) remove lpTokenSupply from pools
853e23b 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) optimize pool contract fetching
c89f274 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) optimize pricing API using analytics API
40dcc08 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) half the allowedSlippage
04f12dc 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) remove ghostnet from plenty config
fa68ed7 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) plenty trading type to AMM
0c84026 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) update failing tests according to new config
210e219 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) optimise plentyBuyTrade paths
489dc70 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@nikspz @OjusWiZard
remove zigzag
eb036ab
@OjusWiZard
(feat) add tezos chain support
2433d6c 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) solve dependency conflict
6602b27 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) failing /poll test
72b9ec2
@OjusWiZard
(fix) failing build from controller
464c203 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard
(fix) failing testcase after rebase
765b702
nikspz
nikspz approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@nikspz nikspz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performed:

  • Cloned and installed PR6475 + gwPR156

  • Created wallet at kukai.app, not able to use passphrase, not going. no private key available

  • Created wallet https://templewallet.com/ and used this private key

  • connected plenty with templewallet key successfully

  • checked balance successfully

  • created amm_arb strategy using plenty succesfully

  • uniswap_ethereum_arbitrum

    • connected wallet successfully, order execution is okay

  • dYdX: connected wallet successfully

  • Dexalot: connected wallet successfully

  • Pancakeswap

    • connected wallet successfully, order execution is okay

Note: Performed test for bronze connector, not tested order execution since no testnet available. Checked gold/silver connectors not affected by the PR

@nikspz nikspz requested a review from cardosofede August 16, 2023 03:19
@rapcmia rapcmia requested a review from fengtality August 16, 2023 12:50
fengtality
fengtality approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@fengtality fengtality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengtality fengtality merged commit 3ebf3c7 into hummingbot:development Aug 20, 2023
@david-hummingbot
Copy link
Contributor

Hi @OjusWiZard, can you also add the docs for the Tezos chain and Plenty to our docs site - https://github.com/hummingbot/hummingbot-site
You can use any of the bronze DEX connectors as a template.

@OjusWiZard
Copy link
Contributor Author

Heyy @david-hummingbot, I've added the PR here.

@nikspz nikspz mentioned this pull request Aug 25, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikspz nikspz nikspz approved these changes

@fengtality fengtality fengtality approved these changes

@cardosofede cardosofede Awaiting requested review from cardosofede

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OjusWiZard @david-hummingbot @fengtality @nikspz