Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/polygon gasd #127

Merged
merged 10 commits into from
Jun 6, 2023
Merged

Fix/polygon gasd #127

merged 10 commits into from
Jun 6, 2023

Conversation

fengtality
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • change default gas setting for Polygon to 400, since gas prices have risen sharply in recent months
Screen Shot 2023-06-05 at 5 52 06 PM

Tips for QA testing:

  • Install fresh Hummingbot + Gateway instance
  • Connect to Uniswap Polygon mainnet
  • Run approve-tokens command on WMATIC

rapcmia and others added 8 commits April 26, 2023 23:03
sync gateway / gateway staging -> master for Hummingbot version 1.15.0
gateway sync / gateway development -> staging
….json

(fix) Update version in package.json
- added job to build and push multi-arch Docker image on merge to master
gateway sync / gateway staging -> main for Hummingbot version 1.16.0
@fengtality fengtality requested review from rapcmia and nikspz June 6, 2023 00:54
Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Setup latest development client and gateway PR127
  • Successfully connected gateway and uniswap-polygon wallet
  • Run gateway approve-token uniswap_polygon_mainnet WMATIC, all ok
  • Crosscheck with development branch and noticed changes between the two ✅
  • Ran tests with docker env both this PR and latest client development 💯

@fengtality fengtality changed the base branch from main to development June 6, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants